chrome_paths: refactor and sanitize cache directory handling

chrome/common/chrome_paths_internal.h

Index: chrome/common/chrome_paths_internal.h
diff --git a/chrome/common/chrome_paths_internal.h b/chrome/common/chrome_paths_internal.h
index 6671e258c77fee14816bebecd8ee7eba32732848..54b89290a994956de5ce04158c9638500d7b99c4 100644
--- a/chrome/common/chrome_paths_internal.h
+++ b/chrome/common/chrome_paths_internal.h
@@ -21,6 +21,13 @@ bool GetDefaultUserDataDirectory(FilePath* result);
 // CF and Google Chrome want to share the same binaries.
 bool GetChromeFrameUserDataDirectory(FilePath* result);
 
+// Get the path to the user's cache directory.  This is normally the
+// same as the profile directory, but on Linux it can also be
+// $XDG_CACHE_HOME and on Mac it can be under ~/Library/Caches.
+// Note that we create subdirectories from this directory, like

[Mark Mentovai, 2010/11/18 16:54:54]

Eh, do you HAVE to say “we?” Can’t you say “this creates?” After all, this
(GetUserCacheDirectory) is what does the creating, not “us” (Evan and Mark?)

[Evan Martin, 2010/11/18 18:13:07]

The caller ends up creating those directories.  But I know your hatred of "we",
so I'll rephrase.

+// "Cache" and "Media Cache".
+bool GetUserCacheDirectory(const FilePath& profile_dir, FilePath* result);
+
 // Get the path to the user's documents directory.
 bool GetUserDocumentsDirectory(FilePath* result);