Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 5122005: Add a fast case to Array.join when all the elements and the separator are fla... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/array.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2754 matching lines...) Expand 10 before | Expand all | Expand 10 after
2765 2765
2766 void FullCodeGenerator::EmitGetCachedArrayIndex(ZoneList<Expression*>* args) { 2766 void FullCodeGenerator::EmitGetCachedArrayIndex(ZoneList<Expression*>* args) {
2767 ASSERT(args->length() == 1); 2767 ASSERT(args->length() == 1);
2768 VisitForAccumulatorValue(args->at(0)); 2768 VisitForAccumulatorValue(args->at(0));
2769 __ ldr(r0, FieldMemOperand(r0, String::kHashFieldOffset)); 2769 __ ldr(r0, FieldMemOperand(r0, String::kHashFieldOffset));
2770 __ IndexFromHash(r0, r0); 2770 __ IndexFromHash(r0, r0);
2771 context()->Plug(r0); 2771 context()->Plug(r0);
2772 } 2772 }
2773 2773
2774 2774
2775 void FullCodeGenerator::EmitFastAsciiArrayJoin(ZoneList<Expression*>* args) {
2776 __ LoadRoot(r0, Heap::kUndefinedValueRootIndex);
2777 context()->Plug(r0);
2778 return;
2779 }
2780
2781
2775 void FullCodeGenerator::VisitCallRuntime(CallRuntime* expr) { 2782 void FullCodeGenerator::VisitCallRuntime(CallRuntime* expr) {
2776 Handle<String> name = expr->name(); 2783 Handle<String> name = expr->name();
2777 if (name->length() > 0 && name->Get(0) == '_') { 2784 if (name->length() > 0 && name->Get(0) == '_') {
2778 Comment cmnt(masm_, "[ InlineRuntimeCall"); 2785 Comment cmnt(masm_, "[ InlineRuntimeCall");
2779 EmitInlineRuntimeCall(expr); 2786 EmitInlineRuntimeCall(expr);
2780 return; 2787 return;
2781 } 2788 }
2782 2789
2783 Comment cmnt(masm_, "[ CallRuntime"); 2790 Comment cmnt(masm_, "[ CallRuntime");
2784 ZoneList<Expression*>* args = expr->arguments(); 2791 ZoneList<Expression*>* args = expr->arguments();
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
3426 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value. 3433 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value.
3427 __ add(pc, r1, Operand(masm_->CodeObject())); 3434 __ add(pc, r1, Operand(masm_->CodeObject()));
3428 } 3435 }
3429 3436
3430 3437
3431 #undef __ 3438 #undef __
3432 3439
3433 } } // namespace v8::internal 3440 } } // namespace v8::internal
3434 3441
3435 #endif // V8_TARGET_ARCH_ARM 3442 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/array.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698