Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 5122005: Add a fast case to Array.join when all the elements and the separator are fla... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/codegen-arm.h ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5798 matching lines...) Expand 10 before | Expand all | Expand 10 after
5809 ASSERT(args->length() == 1); 5809 ASSERT(args->length() == 1);
5810 Load(args->at(0)); 5810 Load(args->at(0));
5811 Register value = frame_->PopToRegister(); 5811 Register value = frame_->PopToRegister();
5812 5812
5813 __ ldr(value, FieldMemOperand(value, String::kHashFieldOffset)); 5813 __ ldr(value, FieldMemOperand(value, String::kHashFieldOffset));
5814 __ IndexFromHash(value, value); 5814 __ IndexFromHash(value, value);
5815 frame_->EmitPush(value); 5815 frame_->EmitPush(value);
5816 } 5816 }
5817 5817
5818 5818
5819 void CodeGenerator::GenerateFastAsciiArrayJoin(ZoneList<Expression*>* args) {
5820 ASSERT(args->length() == 2);
5821 Load(args->at(0));
5822 Register value = frame_->PopToRegister();
5823 __ LoadRoot(value, Heap::kUndefinedValueRootIndex);
5824 frame_->EmitPush(value);
5825 }
5826
5827
5819 void CodeGenerator::VisitCallRuntime(CallRuntime* node) { 5828 void CodeGenerator::VisitCallRuntime(CallRuntime* node) {
5820 #ifdef DEBUG 5829 #ifdef DEBUG
5821 int original_height = frame_->height(); 5830 int original_height = frame_->height();
5822 #endif 5831 #endif
5823 if (CheckForInlineRuntimeCall(node)) { 5832 if (CheckForInlineRuntimeCall(node)) {
5824 ASSERT((has_cc() && frame_->height() == original_height) || 5833 ASSERT((has_cc() && frame_->height() == original_height) ||
5825 (!has_cc() && frame_->height() == original_height + 1)); 5834 (!has_cc() && frame_->height() == original_height + 1));
5826 return; 5835 return;
5827 } 5836 }
5828 5837
(...skipping 1436 matching lines...) Expand 10 before | Expand all | Expand 10 after
7265 BinaryOpIC::GetName(runtime_operands_type_)); 7274 BinaryOpIC::GetName(runtime_operands_type_));
7266 return name_; 7275 return name_;
7267 } 7276 }
7268 7277
7269 7278
7270 #undef __ 7279 #undef __
7271 7280
7272 } } // namespace v8::internal 7281 } } // namespace v8::internal
7273 7282
7274 #endif // V8_TARGET_ARCH_ARM 7283 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/codegen-arm.h ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698