Issue 5121009: Switching chrome to use python26 in place of python24.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5121009: Switching chrome to use python26 in place of python24. (Closed)

Created:
10 years, 1 month ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
nsylvain, M-A Ruel, Nirnimesh

CC:
chromium-reviews, amit

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Switching chrome to use python26 in place of python24. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67000

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
M	DEPS	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ceee/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/chrome_frame_launcher.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

On 2010/11/18 21:51:45, nsylvain wrote: > LGTM. (you should gcl try if you haven't yet) ...

10 years, 1 month ago (2010-11-22 21:34:34 UTC) #4

bradn

10 years, 1 month ago (2010-11-22 21:58:31 UTC) #5

Ok, sorted out pyauto in separate review.
Landing went ok, except for bad nacl rev, trying again once I've got that
sorted out.

-BradN

On Mon, Nov 22, 2010 at 1:34 PM, <nirnimesh@chromium.org> wrote:

> On 2010/11/18 21:51:45, nsylvain wrote:
>
>> LGTM.  (you should gcl try if you haven't yet)
>>
>
> This breaks pyauto in a number of ways.
> The scripts that fire off pyauto need to now know how to pick python2.6
>
>
> http://codereview.chromium.org/5121009/
>

Expand Messages | Collapse Messages