Issue 5121008: AU: Check the delta magic and fail on mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5121008: AU: Check the delta magic and fail on mismatch. (Closed)

Created:
10 years, 1 month ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git@master

Visibility:
Public.

Description

AU: Check the delta magic and fail on mismatch. This patch also fixes an issue where update_engine may keep the rootfs/kernel file handles open when it fails to apply an update and the delta performer is closed prematurely. BUG=7645 TEST=unit tests, tested on device Change-Id: If5706e0f5dd69fb728d97fc35c83f25cba144c4d Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=934bb41

Patch Set 1 #

Patch Set 2 : fix comment #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -7 lines)			Patch
	M	delta_performer.cc	View	1	3 chunks	+12 lines, -7 lines	0 comments	Download
	M	delta_performer_unittest.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM thanks!

Expand Messages | Collapse Messages