Issue 5121007: Make count-line-ends use StringSearch and only iterate over the source once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5121007: Make count-line-ends use StringSearch and only iterate over the source once. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

Make count-line-ends use StringSearch and only iterate over the source once.

Patch Set 2 : Now relative to tip of bleeding edge. #

Total comments: 2

Patch Set 3 : Address review comment. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -29 lines)			Patch
	M	src/handles.cc	View	1 2	3 chunks	+37 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/5121007/diff/3001/src/handles.cc File src/handles.cc (right): http://codereview.chromium.org/5121007/diff/3001/src/handles.cc#newcode537 src/handles.cc:537: if (!src->IsFlat()) FlattenString(src); src = FlattenGetString(src)? this will ...

10 years, 1 month ago (2010-11-18 10:36:08 UTC) #2

Lasse Reichstein

10 years, 1 month ago (2010-11-18 10:40:55 UTC) #3

http://codereview.chromium.org/5121007/diff/3001/src/handles.cc
File src/handles.cc (right):

http://codereview.chromium.org/5121007/diff/3001/src/handles.cc#newcode537
src/handles.cc:537: if (!src->IsFlat()) FlattenString(src);
On 2010/11/18 10:36:08, Vyacheslav Egorov wrote:
> src = FlattenGetString(src)?
> 
> this will allow to remove ConsString handling below.

Done.