Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 512003: Create a method to push an image to a live running Chromium OS machine (Closed)

Created:
11 years ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
petkov, sosa
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Create a method to push an image to a live running Chromium OS machine provided you have root ssh access with a local private key (which is the case for test builds). Updates the running instance and reboots it.

Patch Set 1 #

Patch Set 2 : Reformatting. #

Patch Set 3 : Typos #

Patch Set 4 : Kill devservers at end of script and use release description not version as its more informative. #

Patch Set 5 : <=80 cols #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -0 lines) Patch
A src/scripts/image_to_live.sh View 1 2 3 4 1 chunk +204 lines, -0 lines 5 comments Download

Messages

Total messages: 3 (0 generated)
kmixter1
11 years ago (2009-12-22 23:54:10 UTC) #1
sosa
Looks good to me. You may want to add the pkill -f to the end ...
11 years ago (2009-12-23 00:12:31 UTC) #2
petkov
11 years ago (2009-12-23 02:00:38 UTC) #3
A few comments but nothing critical -- feel free to submit as-is if you like.

http://codereview.chromium.org/512003/diff/7001/4002
File src/scripts/image_to_live.sh (right):

http://codereview.chromium.org/512003/diff/7001/4002#newcode7
src/scripts/image_to_live.sh:7: # Script to convert the output of build_image.sh
to a usb image.
Please change description.

http://codereview.chromium.org/512003/diff/7001/4002#newcode60
src/scripts/image_to_live.sh:60: function remote_reboot_sh {
A bit confusing name because the routine has nothing to do with reboot.

http://codereview.chromium.org/512003/diff/7001/4002#newcode93
src/scripts/image_to_live.sh:93: echo "Forcing update independent of the current
version"
This change adds an -f flag to force update.
http://codereview.chromium.org/503088

http://codereview.chromium.org/512003/diff/7001/4002#newcode131
src/scripts/image_to_live.sh:131: # The softwareupdate.log gets pretty bit with
download progress
s/bit/big/

http://codereview.chromium.org/512003/diff/7001/4002#newcode166
src/scripts/image_to_live.sh:166: # This may fail while the machine is done so
generate output and a
The "right" way to do this is to babysit the boot process by checking the
boot_id:
/proc/sys/kernel/random/boot_id

Powered by Google App Engine
This is Rietveld 408576698