Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 5120002: TestShell: Backported EventSender.contextClick() improvement (Closed)

Created:
10 years, 1 month ago by gmorrita
Modified:
9 years, 7 months ago
Reviewers:
tkent
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

TestShell: Backported EventSender.contextClick() improvement to mock menu item strings. BUG=63460 TEST=LayoutTest/editing/spelling/context-menu-suggestions.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66603

Patch Set 1 #

Patch Set 2 : Fixed style errors. #

Total comments: 4

Patch Set 3 : Addressed feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
M webkit/tools/test_shell/event_sending_controller.cc View 1 2 3 chunks +55 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/mock_spellcheck.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/mock_spellcheck.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 2 chunks +11 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gmorrita
Hi Kent-san, could you take a look?
10 years, 1 month ago (2010-11-17 12:38:17 UTC) #1
tkent
r- because of some style errors. http://codereview.chromium.org/5120002/diff/2001/webkit/tools/test_shell/event_sending_controller.cc File webkit/tools/test_shell/event_sending_controller.cc (right): http://codereview.chromium.org/5120002/diff/2001/webkit/tools/test_shell/event_sending_controller.cc#newcode786 webkit/tools/test_shell/event_sending_controller.cc:786: { "{" should ...
10 years, 1 month ago (2010-11-18 01:38:46 UTC) #2
tkent
Also, you should use try servers for layout tests.
10 years, 1 month ago (2010-11-18 01:39:37 UTC) #3
gmorrita
Hi, thank you for reviewing! I updated patch, sending a request to trybots. http://codereview.chromium.org/5120002/diff/2001/webkit/tools/test_shell/event_sending_controller.cc File ...
10 years, 1 month ago (2010-11-18 03:33:38 UTC) #4
tkent
10 years, 1 month ago (2010-11-18 09:42:19 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698