Rename SessionManager to ScreenRecorder

Rename SessionManager to ScreenRecorder

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68396

[dmac, 2010-11-17 16:37:53]

http://codereview.chromium.org/5118002/diff/1/remoting/host/chromoting_host.h
File remoting/host/chromoting_host.h (right):

http://codereview.chromium.org/5118002/diff/1/remoting/host/chromoting_host.h...
remoting/host/chromoting_host.h:47: //    Also create a ScreenRecorder with
appropriate Encoder and Capturer and
the english here is bad...

We will create a ConnectionToClient object that wraps around libjingle for
transporting screen captures. We will then create a ScreenRecorder with an
Encoder and a Capturer, and then inject the ConnectionToClient into this
ScreenRecorder.

http://codereview.chromium.org/5118002/diff/1/remoting/host/chromoting_host.h...
remoting/host/chromoting_host.h:57: // 3. When the user is disconencted, we will
pause the ScreenRecorder
disconnected

http://codereview.chromium.org/5118002/diff/1/remoting/host/chromoting_host.h...
remoting/host/chromoting_host.h:132: // constructed this is set to NULL.
this comment makes no sense.

http://codereview.chromium.org/5118002/diff/1/remoting/host/screen_recorder_u...
File remoting/host/screen_recorder_unittest.cc (right):

http://codereview.chromium.org/5118002/diff/1/remoting/host/screen_recorder_u...
remoting/host/screen_recorder_unittest.cc:55: Init();
why do we use Init() instead of SetUp?

[Alpha Left Google, 2010-11-17 21:29:16]

Fixed all comments.

[dmac, 2010-11-17 21:58:19]

http://codereview.chromium.org/5118002/diff/6001/remoting/host/screen_recorde...
File remoting/host/screen_recorder_unittest.cc (right):

http://codereview.chromium.org/5118002/diff/6001/remoting/host/screen_recorde...
remoting/host/screen_recorder_unittest.cc:47: MockCapturer* capturer_;
what's the ownership on these guys? It looks like a leak in SetUp.

[Alpha Left Google, 2010-11-19 23:19:21]

http://codereview.chromium.org/5118002/diff/6001/remoting/host/screen_recorde...
File remoting/host/screen_recorder_unittest.cc (right):

http://codereview.chromium.org/5118002/diff/6001/remoting/host/screen_recorde...
remoting/host/screen_recorder_unittest.cc:47: MockCapturer* capturer_;
On 2010/11/17 21:58:19, dmac wrote:
> what's the ownership on these guys? It looks like a leak in SetUp.

capturer_ and encoder_ are deleted by ScreenRecorder. Added comment for that.

[dmac, 2010-11-19 23:24:23]

LGTM with comment nits.

http://codereview.chromium.org/5118002/diff/10001/remoting/host/chromoting_ho...
File remoting/host/chromoting_host.h (right):

http://codereview.chromium.org/5118002/diff/10001/remoting/host/chromoting_ho...
remoting/host/chromoting_host.h:47: //    A ScreenRecorder is created with
Encoder and Capturer.
with an Encoder and a Capturer.

http://codereview.chromium.org/5118002/diff/10001/remoting/host/chromoting_ho...
remoting/host/chromoting_host.h:48: //    ConnectionToClient is added to this
SCreenRecorder for transporting
A ConnectionToClient is added to the ScreenRecorder

http://codereview.chromium.org/5118002/diff/10001/remoting/host/screen_record...
File remoting/host/screen_recorder_unittest.cc (right):

http://codereview.chromium.org/5118002/diff/10001/remoting/host/screen_record...
remoting/host/screen_recorder_unittest.cc:36: capturer_ = new MockCapturer();
Could you add the comment about ownership here instead? because this is where it
looks like there is a bug.