Issue 5116002: Adding the possibility to resize the "Edit Bookmark" dialog....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5116002: Adding the possibility to resize the "Edit Bookmark" dialog.... (Closed)

Created:
10 years, 1 month ago by Peter Beverloo

Modified:
9 years, 4 months ago

Reviewers:
Nico, sky

CC:
chromium-reviews, ben+cc_chromium.org, tfarina, viettrungluu

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Adding the possibility to resize the "Edit Bookmark" dialog. BUG=60966 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66424

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -0 lines)			Patch
M	AUTHORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmark_editor_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmark_editor_view.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

Try jobs came back green, and this LGTM, so I'll just land this (risking that ...

10 years, 1 month ago (2010-11-17 12:27:09 UTC) #1

sky

On 2010/11/17 12:27:09, Nico wrote: > Try jobs came back green, and this LGTM, so ...

10 years, 1 month ago (2010-11-17 15:56:19 UTC) #2

Nico

On Wed, Nov 17, 2010 at 4:56 PM, <sky@chromium.org> wrote: > On 2010/11/17 12:27:09, Nico ...

10 years, 1 month ago (2010-11-17 15:58:22 UTC) #3

sky

10 years, 1 month ago (2010-11-17 16:01:37 UTC) #4

On Wed, Nov 17, 2010 at 7:58 AM, Nico Weber <thakis@chromium.org> wrote:
> On Wed, Nov 17, 2010 at 4:56 PM,  <sky@chromium.org> wrote:
>> On 2010/11/17 12:27:09, Nico wrote:
>>>
>>> Try jobs came back green, and this LGTM, so I'll just land this (risking
>>> that
>>
>> it
>>>
>>> might get reverted if sky says this is all wrong – but that'd surprise
>>> me).
>>
>>> Thanks for the patch!
>>
>> Are the other platforms already resizable?
>
> Mac is. I don't know about linux.
>

I just tried, looks like linux is already resizable so WIndows was the
only one that wasn't.

Thanks for the fix Peter.

  -Scott

Expand Messages | Collapse Messages