Omnibox tests for,...

functional/omnibox.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import glob
 import os
 import re
 import shutil
 import tempfile
 import urlparse
 
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
 
 
@@ skipping 190 matching lines @@
     matches = self._GetOmniboxMatchesFor('apple')
     self.assertTrue(matches)
     self.assertTrue([x for x in matches if x['type'] == 'search-suggest'])
     # Disable suggest-service
     self.SetPrefs(pyauto.kSearchSuggestEnabled, False)
     self.assertFalse(self.GetPrefsInfo().Prefs(pyauto.kSearchSuggestEnabled))
     matches = self._GetOmniboxMatchesFor('apple')
     self.assertTrue(matches)
     # Verify there are no suggest results
     self.assertFalse([x for x in matches if x['type'] == 'search-suggest'])
-
+ 

[Nirnimesh, 2010/12/22 19:32:51]

remove stray whitespace chars

   def _CheckBookmarkResultForVariousInputs(self, url, title, windex=0):
     """Check if we get the Bookmark for complete and partial inputs."""
     # Check if the complete URL would get the bookmark
     url_matches = self._GetOmniboxMatchesFor(url, windex=windex)
     self._VerifyHasBookmarkResult(url_matches)
     # Check if the complete title would get the bookmark
     title_matches = self._GetOmniboxMatchesFor(title, windex=windex)
     self._VerifyHasBookmarkResult(title_matches)
     # Check if the partial URL would get the bookmark
     split_url = urlparse.urlsplit(url)
     partial_url = self._GetOmniboxMatchesFor(split_url.scheme, windex=windex)
     self._VerifyHasBookmarkResult(partial_url)
     # Check if the partial title would get the bookmark
     split_title = title.split()
     search_term = split_title[len(split_title) - 1]
     partial_title = self._GetOmniboxMatchesFor(search_term, windex=windex)
     self._VerifyHasBookmarkResult(partial_title)
 
+  def _CheckMatches(self, old_matches_len, search_text):

[Nirnimesh, 2010/12/22 19:32:51]

Be more descriptive with the name.
Or at least provide a descriptive docstring

+    new_matches = self._GetOmniboxMatchesFor(search_text) 
+    if len(new_matches) > old_matches_len:
+      return True
+    return False
+
+  def testContentHisotry(self):
+    """Verify omnibox results when entering page content
+       
+    Test verifies that visited page shows up in omnibox on entering page
+    content.
+    """
+    search_text = 'British throne'
+    old_matches = self._GetOmniboxMatchesFor(search_text)
+    url = self.GetFileURLForPath(
+        os.path.join(self.DataDir(), 'find_in_page', 'largepage.html'))
+    self.AppendTab(pyauto.GURL(url))
+    self.WaitUntil(lambda: self._CheckMatches(len(old_matches), search_text))

[Nirnimesh, 2010/12/22 19:32:51]

wrap this inside self.assertTrue()

Be aware that waitUntil has a timeout of ~30 secs

+    matches = self._GetOmniboxMatchesFor(search_text)
+    matches_description = [x for x in matches if x['destination_url'] == url]
+    self.assertEqual(1, len(matches_description))
+
+  def testRecentPageHistory(self):

[Nirnimesh, 2010/12/22 19:32:51]

In the interest of saving time it might be useful to somehow combine this with
the last test.

+    """Verify that omnibox shows recent history option in the visited
+       url list."""
+    search_text = 'file'
+    sites = glob.glob(os.path.join(self.DataDir(), 'find_in_page', '*.html')) 
+    for site in sites:
+      self.NavigateToURL(self.GetFileURLForPath(site))
+    old_matches = self._GetOmniboxMatchesFor(search_text)
+    # Using max timeout as 40 seconds, since expected page only shows up
+    # after 40 seconds and default timeout is less than that.
+    self.WaitUntil(lambda: self._CheckMatches(len(old_matches), search_text),

[Nirnimesh, 2010/12/22 19:32:51]

wrap inside self.assertTrue

+                   timeout=40)
+    matches = self._GetOmniboxMatchesFor(search_text)
+    matches_description = [x for x in matches if x['type'] ==
+                           'open-history-page']
+    self.assertEqual(1, len(matches_description))
+
   def _VerifyHasBookmarkResult(self, matches):
     """Verify that we have a bookmark result."""
     matches_starred = [result for result in matches if result['starred']]
     self.assertTrue(matches_starred)
     self.assertEqual(1, len(matches_starred))
 
   def testBookmarkResultInNewTabAndWindow(self):
     """Verify that omnibox can recognize bookmark in the search options
     in new tabs and Windows.
     """
@@ skipping 12 matching lines @@
     self.NavigateToURL(url, 1, 0)
     self._CheckBookmarkResultForVariousInputs(url, title, windex=1)
     self.RunCommand(pyauto.IDC_NEW_INCOGNITO_WINDOW)
     self.assertEqual(3, self.GetBrowserWindowCount())
     self.NavigateToURL(url, 2, 0)
     self._CheckBookmarkResultForVariousInputs(url, title, windex=2)
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()