Issue 5114001: Further cleanup of delegate==NULL cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5114001: Further cleanup of delegate==NULL cases. (Closed)

Created:
10 years, 1 month ago by kochi

Modified:
9 years, 7 months ago

Reviewers:
stevenjb, satorux1, Zachary Kuznia

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

* Change LOG(INFO) to LOG(WARNING) to reduce noise in log. * Better handling of delegate==NULL case, not just use shortcut to return safe value, but rather exercise the following path assuming the call to delegate returns some safe default. BUG=chromium-os:8958 TEST=Open incognito window, close all tabs in normal window, then close all tabs in incognito window and do not observe any crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66391

Patch Set 1 #

Patch Set 2 : Further cleanup of delegate == NULL cases. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -29 lines)			Patch
	M	chrome/browser/ui/views/frame/opaque_browser_frame_view.cc	View	1	7 chunks	+14 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

On 2010/11/17 01:43:25, Takayoshi Kochi wrote: LGTM Thanks!

10 years, 1 month ago (2010-11-17 01:48:03 UTC) #2

Zachary Kuznia

10 years, 1 month ago (2010-11-17 02:26:52 UTC) #3

On 2010/11/17 01:48:03, Steven Bennetts wrote:
> On 2010/11/17 01:43:25, Takayoshi Kochi wrote:
> 
> LGTM
> Thanks!

LGTM

Expand Messages | Collapse Messages