chrome/browser/ui/views/frame/browser_view.cc - Issue 5111002: Fixes bug where instant dim was not removed correctly if you pressed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 5111002: Fixes bug where instant dim was not removed correctly if you pressed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 3e2dbf82129b781b4ded8b96641835b27d602928..2bf7e78dfdaa7124c319beffec1f39b85f4ef5fe 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1365,8 +1365,10 @@ void BrowserView::ShowInstant(TabContents* preview_contents) {

}

void BrowserView::HideInstant() {

- if (!preview_container_)

+ if (!preview_container_) {

+ contents_->RemoveFade();

return;

+ }

// The contents must be changed before SetPreview is invoked.

preview_container_->ChangeTabContents(NULL);

« no previous file with comments | « no previous file | no next file » | no next file with comments »