A non-GTK version of menus for touchui.

base/message_pump_glib_x.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_pump_glib_x.h"
 
 #include <gdk/gdkx.h>
 #if defined(HAVE_XINPUT2)
 #include <X11/extensions/XInput2.h>
 #else
@@ skipping 67 matching lines @@
 #endif
   InitializeEventsToCapture();
 }
 
 MessagePumpGlibX::~MessagePumpGlibX() {
 }
 
 bool MessagePumpGlibX::RunOnce(GMainContext* context, bool block) {
   GdkDisplay* gdisp = gdk_display_get_default();
   Display* display = GDK_DISPLAY_XDISPLAY(gdisp);
+  static gboolean (*gdkdispatcher)(GSource*, GSourceFunc, void*) = NULL;

[Evan Martin, 2010/11/22 20:43:26]

Is this really the best place for this state?  Why not a member variable?  Is it
shared across all instances of this class?

[sadrul, 2010/11/22 21:23:06]

The default GDK event dispatcher should not change during the lifetime of
chrome, unless it is replaced by something other than the message-pump itself. A
member variable should do just fine. Sounds like that's preferrable. So made
that change.

+
+  if (!gdkdispatcher && gdksource_) {
+    gdkdispatcher = gdksource_->source_funcs->dispatch;
+  }
+
   if (XPending(display)) {
     XEvent xev;
     XPeekEvent(display, &xev);
     if (capture_x_events_[xev.type]
 #if defined(HAVE_XINPUT2)
         && (xev.type != GenericEvent || xev.xcookie.extension == xiopcode_)
 #endif
         ) {
       XNextEvent(display, &xev);
 
+#if defined(HAVE_XINPUT2)
+      bool have_cookie = false;
+      if (xev.type == GenericEvent &&
+          XGetEventData(xev.xgeneric.display, &xev.xcookie)) {
+        have_cookie = true;
+      }
+#endif
+
       bool processed = static_cast<MessagePumpGlibXDispatcher*>
           (GetDispatcher())->Dispatch(&xev);
 
       if (!processed) {
         DLOG(WARNING) << "Event (" << xev.type << ") not handled.";
 
         // TODO(sad): It is necessary to put back the event so that the default
         // GDK events handler can take care of it. Without this, it is
         // impossible to use the omnibox at the moment. However, this will
         // eventually be removed once the omnibox code is updated for touchui.
         XPutBackEvent(display, &xev);
+        if (gdksource_)
+          gdksource_->source_funcs->dispatch = gdkdispatcher;
         g_main_context_iteration(context, FALSE);
       }
+
+#if defined(HAVE_XINPUT2)
+      if (have_cookie) {
+        XFreeEventData(xev.xgeneric.display, &xev.xcookie);
+      }
+#endif
     } else {
       // TODO(sad): A couple of extra events can still sneak in during this.
       // Those should be sent back to the X queue from the dispatcher
       // EventDispatcherX.
+      if (gdksource_)
+        gdksource_->source_funcs->dispatch = gdkdispatcher;
       g_main_context_iteration(context, FALSE);
     }
   }
 
   bool retvalue;
   if (gdksource_) {
     // Replace the dispatch callback of the GDK event source temporarily so that
     // it doesn't read events from X.
     gboolean (*cb)(GSource*, GSourceFunc, void*) =
         gdksource_->source_funcs->dispatch;
@@ skipping 124 matching lines @@
       // X queue so that we catch it in the next iteration. When done, the
       // following DLOG statement will be removed.
       DLOG(WARNING) << "GDK received an event it shouldn't have";
     }
   }
 
   pump_x->DispatchEvents(event);
 }
 
 }  // namespace base