Add an alert for python < 2.5.

Add an alert for python < 2.5.

Don't block execution.

Python 2.4 has been untested for a while and may break unexpectedly.

TEST=manual testing
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66870

[jam, 2010-11-20 03:05:14]

can we update them automatically?  in my case depot_tools\python_bin is 2.4

On Fri, Nov 19, 2010 at 6:59 PM, <maruel@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Description:
> Add an alert for python < 2.5.
>
> Don't block execution.
>
> Python 2.4 has been untested for a while and may break unexpectedly.
>
> TEST=manual testing
> BUG=none
>
> Please review this at http://codereview.chromium.org/5110009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
>
> Affected files:
>  M gcl.py
>  M gclient.py
>
>
> Index: gcl.py
> diff --git a/gcl.py b/gcl.py
> index
>
c0d6685e4ba7edd1f0cb6a71de29755d9c43b3fb..7e54a240d6267f7a4fe073472f8d1ca586159dd3
> 100755
> --- a/gcl.py
> +++ b/gcl.py
> @@ -1351,6 +1351,9 @@ def CMDhelp(args):
>
>
>  def main(argv):
> +  if sys.hexversion < 0x02050000:
> +    print >> sys.stderr, (
> +        '\nYour python version is unsupported, please upgrade.\n')
>   if not argv:
>     argv = ['help']
>   command = Command(argv[0])
> Index: gclient.py
> diff --git a/gclient.py b/gclient.py
> index
>
6817db16940ed7eddd1c2c31e74208fef32fc764..98a81925aad7f69c511a62e30cc751a5ca0ff3d5
> 100644
> --- a/gclient.py
> +++ b/gclient.py
> @@ -1193,6 +1193,9 @@ def GenUsage(parser, command):
>  def Main(argv):
>   """Doesn't parse the arguments here, just find the right subcommand to
>   execute."""
> +  if sys.hexversion < 0x02050000:
> +    print >> sys.stderr, (
> +        '\nYour python version is unsupported, please upgrade.\n')
>   try:
>     # Make stdout auto-flush so buildbot doesn't kill us during lengthy
>     # operations. Python as a strong tendency to buffer sys.stdout.
>
>
>

[M-A Ruel, 2010-11-20 03:10:00]

On 2010/11/20 03:05:14, John Abd-El-Malek wrote:
> can we update them automatically?  in my case depot_tools\python_bin is 2.4

We couldn't previously because of the way the build slaves work. It's probably
possible now. I'll look into it next week; 2.4 needs to die.