Issue 5109012: Fix PrerenderInterceptor leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5109012: Fix PrerenderInterceptor leaks. (Closed)

Created:
10 years, 1 month ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix PrerenderInterceptor leaks. TBR=gavinp BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66911

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	chrome/browser/net/prerender_interceptor_unittest.cc	View		6 chunks	+15 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gavinp

LGTM. Thanks for cleaning up after my mistake, Will. How did you find the leak? ...

10 years, 1 month ago (2010-11-22 03:04:18 UTC) #2

willchan no longer on Chromium

10 years, 1 month ago (2010-11-22 03:25:54 UTC) #3

On Sun, Nov 21, 2010 at 7:04 PM, <gavinp@chromium.org> wrote:

> LGTM.  Thanks for cleaning up after my mistake, Will.
>
> How did you find the leak?
>

http://build.chromium.org/p/chromium.memory/console was failing earlier with
these logfiles:

http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20(valgrin...
http://build.chromium.org/p/chromium.memory/builders/Linux%20Heapcheck/builds...

I just happened to notice it since I was trying to fix some of my leaks too.
 I don't usually check the memory bot page.

>
>
>
>
http://codereview.chromium.org/5109012/diff/1/chrome/browser/net/prerender_in...
> File chrome/browser/net/prerender_interceptor_unittest.cc (right):
>
>
>
http://codereview.chromium.org/5109012/diff/1/chrome/browser/net/prerender_in...
> chrome/browser/net/prerender_interceptor_unittest.cc:68: req_.reset(new
> TestURLRequest(gurl_, &delegate_));
> Thanks.  I clearly didn't think that code through.
>
> I like the cleanup, too.
>
>
> http://codereview.chromium.org/5109012/
>

Expand Messages | Collapse Messages