Issue 5108003: API call code refactoring (x64).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5108003: API call code refactoring (x64). (Closed)

Created:
10 years, 1 month ago by SeRya

Modified:
9 years, 7 months ago

Reviewers:
antonm

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

API call code refactoring (x64). Committed: http://code.google.com/p/v8/source/detail?r=5836

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -54 lines)			Patch
M	src/x64/code-stubs-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1	3 chunks	+16 lines, -15 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		6 chunks	+25 lines, -21 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	11 chunks	+27 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

LGTM http://codereview.chromium.org/5108003/diff/17001/src/x64/macro-assembler-x64.h File src/x64/macro-assembler-x64.h (right): http://codereview.chromium.org/5108003/diff/17001/src/x64/macro-assembler-x64.h#newcode844 src/x64/macro-assembler-x64.h:844: // stack_space * kPointerSize bytes will be removed ...

10 years, 1 month ago (2010-11-17 10:23:08 UTC) #2

SeRya

10 years, 1 month ago (2010-11-17 10:29:27 UTC) #3

Also removed mentions of FastHandleApiCall builtin which is not used in x64 any
more from comments.

http://codereview.chromium.org/5108003/diff/17001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):

http://codereview.chromium.org/5108003/diff/17001/src/x64/macro-assembler-x64...
src/x64/macro-assembler-x64.h:844: // stack_space * kPointerSize bytes will be
removed from stack after the call.
On 2010/11/17 10:23:08, antonm wrote:
> there is no statck_space any more, please, rework the comment

Done.

Expand Messages | Collapse Messages

Issue 5108003: API call code refactoring (x64). (Closed)

Description

Patch Set 1 : '' #

Patch Set 2 : '' #

Messages