[Isolates] Cleanup of codepaths slowing down Dromaeo in browser.

src/log.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 61 matching lines @@
 class Ticker;
 class Profiler;
 class Semaphore;
 class SlidingStateWindow;
 class LogMessageBuilder;
 class CompressionHelper;
 
 #undef LOG
 // TODO(isolates): pass isolate pointer here.
 #ifdef ENABLE_LOGGING_AND_PROFILING
-#define LOG(Call)                                   \
-  do {                                              \
-    v8::internal::Logger* logger =                  \
-        v8::internal::Isolate::Current()->logger(); \
-    if (logger->is_logging())                       \
-      logger->Call;                                 \
+#define LOG_FOR_ISOLATE(isolate, Call)                \
+  do {                                                \
+    v8::internal::Logger* logger = isolate->logger(); \
+    if (logger->is_logging())                         \
+      logger->Call;                                   \
   } while (false)
+
+#define LOG(Call) LOG_FOR_ISOLATE(v8::internal::Isolate::Current(), Call)
 #else
+#define LOG_FOR_ISOLATE(isolate, Call) ((void) 0)

[Vitaly Repeshko, 2010/12/06 18:18:45]

Doing this in two steps will most likely cause too many formatting changes to
make lint happy. Is it too much work to be done in one step?

 #define LOG(Call) ((void) 0)
 #endif
 
 #define LOG_EVENTS_AND_TAGS_LIST(V) \
   V(CODE_CREATION_EVENT,            "code-creation",          "cc")       \
   V(CODE_MOVE_EVENT,                "code-move",              "cm")       \
   V(CODE_DELETE_EVENT,              "code-delete",            "cd")       \
   V(CODE_MOVING_GC,                 "code-moving-gc",         "cg")       \
   V(FUNCTION_CREATION_EVENT,        "function-creation",      "fc")       \
   V(FUNCTION_MOVE_EVENT,            "function-move",          "fm")       \
@@ skipping 309 matching lines @@
 // Class that extracts stack trace, used for profiling.
 class StackTracer : public AllStatic {
  public:
   static void Trace(TickSample* sample);
 };
 
 } }  // namespace v8::internal
 
 
 #endif  // V8_LOG_H_