Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: src/builtins.cc

Issue 5107002: Avoiding repacking payload for v8::Arguments and v8::AccessorInfo (arm). (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1063 matching lines...) Expand 10 before | Expand all | Expand 10 after
1074 ASSERT(object->IsInstanceOf(type)); 1074 ASSERT(object->IsInstanceOf(type));
1075 } 1075 }
1076 1076
1077 #endif 1077 #endif
1078 1078
1079 1079
1080 BUILTIN(FastHandleApiCall) { 1080 BUILTIN(FastHandleApiCall) {
1081 ASSERT(!CalledAsConstructor()); 1081 ASSERT(!CalledAsConstructor());
1082 const bool is_construct = false; 1082 const bool is_construct = false;
1083 1083
1084 // We expect four more arguments: function, callback, call data, and holder. 1084 // We expect four more arguments: callback, function, call data, and holder.
1085 const int args_length = args.length() - 4; 1085 const int args_length = args.length() - 4;
1086 ASSERT(args_length >= 0); 1086 ASSERT(args_length >= 0);
1087 1087
1088 Handle<JSFunction> function = args.at<JSFunction>(args_length); 1088 Object* callback_obj = args[args_length + 2];
1089 Object* callback_obj = args[args_length + 1];
1090 Handle<Object> data = args.at<Object>(args_length + 2);
1091 Handle<JSObject> checked_holder = args.at<JSObject>(args_length + 3);
1092 1089
1093 #ifdef DEBUG 1090 #ifdef DEBUG
1091 Handle<JSFunction> function = args.at<JSFunction>(args_length);
1092 Handle<JSObject> checked_holder = args.at<JSObject>(args_length + 3);
1094 VerifyTypeCheck(checked_holder, function); 1093 VerifyTypeCheck(checked_holder, function);
1095 #endif 1094 #endif
1096 1095
1097 CustomArguments custom;
1098 v8::ImplementationUtilities::PrepareArgumentsData(custom.end(),
1099 *data, *function, *checked_holder);
1100
1101 v8::Arguments new_args = v8::ImplementationUtilities::NewArguments( 1096 v8::Arguments new_args = v8::ImplementationUtilities::NewArguments(
1102 custom.end(), 1097 &args[args_length + 1],
1103 &args[0] - 1, 1098 &args[0] - 1,
1104 args_length - 1, 1099 args_length - 1,
1105 is_construct); 1100 is_construct);
1106 1101
1107 HandleScope scope; 1102 HandleScope scope;
1108 Object* result; 1103 Object* result;
1109 v8::Handle<v8::Value> value; 1104 v8::Handle<v8::Value> value;
1110 { 1105 {
1111 // Leaving JavaScript. 1106 // Leaving JavaScript.
1112 VMState state(EXTERNAL); 1107 VMState state(EXTERNAL);
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
1582 Code* entry = Code::cast(builtins_[i]); 1577 Code* entry = Code::cast(builtins_[i]);
1583 if (entry->contains(pc)) { 1578 if (entry->contains(pc)) {
1584 return names_[i]; 1579 return names_[i];
1585 } 1580 }
1586 } 1581 }
1587 } 1582 }
1588 return NULL; 1583 return NULL;
1589 } 1584 }
1590 1585
1591 } } // namespace v8::internal 1586 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698