Resize synchronization for Linux.

app/gfx/gl/gl_context_linux.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file implements the ViewGLContext and PbufferGLContext classes.
 
 #include "app/gfx/gl/gl_context.h"
 
 #include <GL/osmesa.h>
 
 #include "app/gfx/gl/gl_bindings.h"
 #include "app/gfx/gl/gl_context_egl.h"
 #include "app/gfx/gl/gl_context_osmesa.h"
 #include "app/gfx/gl/gl_context_stub.h"
 #include "app/gfx/gl/gl_implementation.h"
 #include "app/x11_util.h"
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/scoped_ptr.h"
+#include "chrome/common/child_thread.h"
+#include "chrome/common/gpu_messages.h"
 
 namespace gfx {
 
 typedef GLXContext GLContextHandle;
 typedef GLXPbuffer PbufferHandle;
 
 class BaseLinuxGLContext : public GLContext {
  public:
   virtual std::string GetExtensions();
 };
@@ skipping 10 matching lines @@
 
   // Initializes the GL context.
   bool Initialize(bool multisampled);
 
   virtual void Destroy();
   virtual bool MakeCurrent();
   virtual bool IsCurrent();
   virtual bool IsOffscreen();
   virtual bool SwapBuffers();
   virtual gfx::Size GetSize();
+  virtual void SetSize(gfx::Size size);
   virtual void* GetHandle();
   virtual void SetSwapInterval(int interval);
 
  private:
   gfx::PluginWindowHandle window_;
   GLContextHandle context_;
 
   DISALLOW_COPY_AND_ASSIGN(ViewGLContext);
 };
 
@@ skipping 248 matching lines @@
   return true;
 }
 
 gfx::Size ViewGLContext::GetSize() {
   XWindowAttributes attributes;
   Display* display = x11_util::GetXDisplay();
   XGetWindowAttributes(display, window_, &attributes);
   return gfx::Size(attributes.width, attributes.height);
 }
 
+void ViewGLContext::SetSize(gfx::Size size) {
+  // Need to flush the GL commands in flight so that the resize operation
+  // doesn't damage the backbuffer.
+  glFinish();
+
+  ChildThread* gpu_thread = ChildThread::current();
+  bool result = false;
+  gpu_thread->Send(
+      new GpuHostMsg_ResizeXID(window_, size.width(), size.height(), &result));

[Ken Russell (switch to Gerrit), 2010/11/22 22:49:52]

This violates a large number of abstraction barriers. app/ isn't allowed to
reach up and touch chrome/ . You'll need to figure out a different structuring.
If the message needs to be sent in response to setting the context's size, then
I suggest adding a callback to the GLContext class and setting that callback
(which would do this work) in gpu_processor_linux.cc.

[jonathan.backer, 2010/11/23 16:41:13]

Done. Thanks for catching this. I used your callback suggestion, but I had to go
one level higher up to GpuCommandBufferStub to satisfy checkdeps.

+}
+
 void* ViewGLContext::GetHandle() {
   return context_;
 }
 
 void ViewGLContext::SetSwapInterval(int interval) {
   DCHECK(IsCurrent());
   if (HasExtension("GLX_EXT_swap_control") && glXSwapIntervalEXT) {
     Display* display = x11_util::GetXDisplay();
     glXSwapIntervalEXT(display, window_, interval);
   }
@@ skipping 473 matching lines @@
     }
     case kGLImplementationMockGL:
       return new StubGLContext;
     default:
       NOTREACHED();
       return NULL;
   }
 }
 
 }  // namespace gfx