Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 5104007: AU: Add unit tests for the Terminator class. (Closed)

Created:
10 years, 1 month ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Add unit tests for the Terminator class. Also, improve the implementation so that the Terminator can be initialized multiple times. BUG=6243 TEST=unit tests Change-Id: I8d7f1a2007ac28f8c79506f46d628654413b6607 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=80f1956

Patch Set 1 #

Patch Set 2 : unnecessary header file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M SConstruct View 1 chunk +1 line, -0 lines 0 comments Download
M terminator.h View 3 chunks +6 lines, -0 lines 0 comments Download
M terminator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A terminator_unittest.cc View 1 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
10 years, 1 month ago (2010-11-19 18:42:39 UTC) #1
adlr
10 years, 1 month ago (2010-11-19 19:30:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698