Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: bin/cros_au_test_harness.py

Issue 5104006: Don't pass "" to cros_run_vm_test if vm_graphics_flag isn't set. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/cros_au_test_harness.py
diff --git a/bin/cros_au_test_harness.py b/bin/cros_au_test_harness.py
index 7342310ce7f7b913a8e92d29c6e7f932db1847d7..bedd16e094a1b89d8ea06cd7b2a08dec071f00ef 100755
--- a/bin/cros_au_test_harness.py
+++ b/bin/cros_au_test_harness.py
@@ -274,15 +274,20 @@ class VirtualAUTest(unittest.TestCase, AUTest):
"""Runs vm smoke suite to verify image."""
# image_to_live already verifies lsb-release matching. This is just
# for additional steps.
- output = RunCommand(['%s/cros_run_vm_test' % self.crosutilsbin,
- '--image_path=%s' % self.vm_image_path,
- '--snapshot',
- '--persist',
- vm_graphics_flag,
- '--kvm_pid=%s' % _KVM_PID_FILE,
- '--test_case=%s' % _VERIFY_SUITE,
- ], error_ok=True, enter_chroot=False,
- redirect_stdout=True)
+
+ commandWithArgs = ['%s/cros_run_vm_test' % self.crosutilsbin,
+ '--image_path=%s' % self.vm_image_path,
+ '--snapshot',
+ '--persist',
+ '--kvm_pid=%s' % _KVM_PID_FILE,
+ _VERIFY_SUITE,
+ ]
+
+ if vm_graphics_flag:
+ commandWithArgs.append(vm_graphics_flag)
+
+ output = RunCommand(commandWithArgs, error_ok=True, enter_chroot=False,
+ redirect_stdout=True)
return self.CommonVerifyImage(self, output, percent_required_to_pass)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698