Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 5103004: Add --payload option to take advantage of the new option for devserver. (Closed)

Created:
10 years, 1 month ago by dgarrett
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add --payload option to take advantage of the new option for devserver. Change-Id: Icdd0a809a2f5aeaedccb2ed421984d9f298f181b BUG=chromium-os:8207 TEST=Ran by hand Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a82ac9a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix code review nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M image_to_live.sh View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgarrett
10 years, 1 month ago (2010-11-17 21:36:12 UTC) #1
dgarrett
10 years, 1 month ago (2010-11-17 21:40:20 UTC) #2
sosa
LGTM w/ nit http://codereview.chromium.org/5103004/diff/1/image_to_live.sh File image_to_live.sh (right): http://codereview.chromium.org/5103004/diff/1/image_to_live.sh#newcode37 image_to_live.sh:37: DEFINE_string payload "" \ alphabetical order ...
10 years, 1 month ago (2010-11-18 02:00:40 UTC) #3
sosa
10 years, 1 month ago (2010-11-18 02:00:40 UTC) #4
LGTM w/ nit

Powered by Google App Engine
This is Rietveld 408576698