Issue 5102010: Passing SSH-options for server tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5102010: Passing SSH-options for server tests. (Closed)

Created:
10 years, 1 month ago by ericli

Modified:
9 years, 7 months ago

Reviewers:
truty

CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org, thieule

Base URL:
http://git.chromium.org/git/autotest.git@master

Visibility:
Public.

Description

The original CL 5188004 only takes care of client side tests and missed the opportunities to support server side control file, since there are lots of occurrence of hosts.create_host(hostname) call inside the server control file. I had to find a better way to pass ssh-options into hosts.create_host() function. Reported by Thieu Le. Change-Id: Ia48793fd73fec1b032a4e3fc1d8505d31431087a BUG=9321 TEST=run client/server side sleeptest against a remote VM. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=10222b8

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -5 lines)			Patch
M	server/hosts/factory.py	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	server/hosts/ssh_host.py	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	server/server_job.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

truty

10 years, 1 month ago (2010-11-23 20:07:26 UTC) #2

lgtm

http://codereview.chromium.org/5102010/diff/1/server/hosts/factory.py
File server/hosts/factory.py (right):

http://codereview.chromium.org/5102010/diff/1/server/hosts/factory.py#newcode70
server/hosts/factory.py:70: 
These are sort of magical since they're injected by server_job. Maybe a comment?

Expand Messages | Collapse Messages