Issue 51007: Formatting changes and some slight improvements to revision 1621, issue 42006...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 51007: Formatting changes and some slight improvements to revision 1621, issue 42006... (Closed)

Created:
11 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Formatting changes and some slight improvements to revision 1621, issue 42006. Committed: http://code.google.com/p/v8/source/detail?r=1634

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -24 lines)			Patch
	M	src/codegen-ia32.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/codegen-ia32.cc	View	1	9 chunks	+27 lines, -22 lines	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Chromium)

11 years, 9 months ago (2009-03-27 12:17:33 UTC) #2

Does this mean we can get rid of NO_SMI_CODE from the stub's flags, and switch
back to a single bit flag encoding?

LGTM otherwise.