Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 51001: Add a new "pseudo" platform for POSIX (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Add a new "pseudo" platform for POSIX. It it will contain code shared by the platforms supporting POSIX. Currently Linux, Mac OS and FreeBSD are considered POSIX platforms using the POSIX implementation. Initially the platform socket implementation has been moved from the Linux, Mac OS and FreeBSD platforms to the POSIX platform. If implementation which ends up in the POSIX platform at some point cannot be the same across POSIX platforms the implementation can easily be moved back into the individual POSIX "complient" platforms. Committed: http://code.google.com/p/v8/source/detail?r=1583

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -533 lines) Patch
M src/SConscript View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/platform-freebsd.cc View 1 3 chunks +2 lines, -174 lines 0 comments Download
M src/platform-linux.cc View 1 3 chunks +2 lines, -175 lines 0 comments Download
M src/platform-macos.cc View 1 3 chunks +2 lines, -180 lines 0 comments Download
A src/platform-posix.cc View 1 chunk +219 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-20 14:31:42 UTC) #1
Erik Corry
11 years, 9 months ago (2009-03-23 15:42:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698