Issue 5094003: Extract extensions to a separate directory....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5094003: Extract extensions to a separate directory.... (Closed)

Created:
10 years, 1 month ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Extract extensions to a separate directory. Remove extensions from the external reference table. They should never be part of the serialized code. Create extensions/experimental subdirectory for experimental extensions not officially supported by V8. Committed: http://code.google.com/p/v8/source/detail?r=5838

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+320 lines, -158 lines)			Patch
M	src/SConscript	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/execution.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	src/execution.cc	View	1 chunk	+0 lines, -131 lines	0 comments	Download
A	src/extensions/externalize-string-extension.h	View	1 chunk	+50 lines, -0 lines	0 comments	Download
A	src/extensions/externalize-string-extension.cc	View	1 chunk	+141 lines, -0 lines	0 comments	Download
A	src/extensions/gc-extension.h	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	src/extensions/gc-extension.cc	View	1 chunk	+54 lines, -0 lines	0 comments	Download
M	src/serialize.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/visual_studio/v8_base.vcproj	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM if all tests pass with and without snapshots.

Expand Messages | Collapse Messages