Issue 5092009: crash-reporter: use HTTPS when sending crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5092009: crash-reporter: use HTTPS when sending crashes (Closed)

Created:
10 years, 1 month ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/crash-reporter.git@master

Visibility:
Public.

Description

crash-reporter: use HTTPS when sending crashes Change-Id: Ibca5616ba449dd1f96ae418a46b372d1a2f55412 BUG=9352 TEST=manual update and User/CrashSender Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5f4b9e5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change location #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	crash_sender	View	1	4 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM w/ a couple of comments. http://codereview.chromium.org/5092009/diff/1/crash_sender File crash_sender (right): http://codereview.chromium.org/5092009/diff/1/crash_sender#newcode65 crash_sender:65: # a certificate ...

10 years, 1 month ago (2010-11-18 22:21:47 UTC) #2

petkov

Btw, have you tested that uploading with an empty ca-certificates directory fails?

10 years, 1 month ago (2010-11-18 22:29:20 UTC) #3

kmixter1

10 years, 1 month ago (2010-11-19 00:44:12 UTC) #4

I tried without c_rehash, but now just tried with an empty directory and it
also correctly fails.

So pushing...

On Thu, Nov 18, 2010 at 2:29 PM, <petkov@chromium.org> wrote:

> Btw, have you tested that uploading with an empty ca-certificates directory
> fails?
>
>
>
> http://codereview.chromium.org/5092009/
>

Expand Messages | Collapse Messages