Issue 509029: Fix mac x64 build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 509029: Fix mac x64 build.

Created:
11 years ago by ry

Modified:
11 years ago

Reviewers:
antonm

CC:
v8-dev

Visibility:
Public.

Description

Fix mac x64 build. This is similar to the issue resolved in r3086 http://codereview.chromium.org/284012

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/x64/fast-codegen-x64.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

11 years ago (2009-12-22 18:53:25 UTC) #1

The mac x64 debug build is failing with:

g++ -o obj/debug/x64/fast-codegen-x64.o -c -Wall -Werror -W
-Wno-unused-parameter -Wnon-virtual-dtor -pedantic -m64 -g -O0 -ansi
-mmacosx-version-min=10.4 -fno-rtti -fno-exceptions -Wall -Werror -W
-Wno-unused-parameter -Wnon-virtual-dtor -pedantic -m64 -g -O0 -ansi
-mmacosx-version-min=10.4 -DV8_TARGET_ARCH_X64 -DENABLE_DISASSEMBLER -DDEBUG
-DENABLE_DEBUGGER_SUPPORT -DV8_NATIVE_REGEXP -DV8_ENABLE_CHECKS
-DENABLE_LOGGING_AND_PROFILING -I/Users/ryah/node/deps/v8/src
/Users/ryah/node/deps/v8/src/x64/fast-codegen-x64.cc
/Users/ryah/node/deps/v8/src/x64/fast-codegen-x64.cc: In member function 'void
v8::internal::FastCodeGenerator::StoreToFrameField(int,
v8::internal::Register)':
/Users/ryah/node/deps/v8/src/x64/fast-codegen-x64.cc:1681: error: call of
overloaded 'CheckEqualsHelper(const char [53], int, const char [68], long int,
const char [36], intptr_t)' is ambiguous
/Users/ryah/node/deps/v8/src/checks.h:75: note: candidates are: void
CheckEqualsHelper(const char*, int, const char*, int, const char*, int)
/Users/ryah/node/deps/v8/src/checks.h:89: note:                 void
CheckEqualsHelper(const char*, int, const char*, int64_t, const char*, int64_t)
/Users/ryah/node/deps/v8/src/checks.h:187: note:                 void
CheckEqualsHelper(const char*, int, const char*, double, const char*, double)
scons: *** [obj/debug/x64/fast-codegen-x64.o] Error 1
scons: building terminated because of errors.


This change fixes it.

Expand Messages | Collapse Messages