Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 509006: Remove complicated Math.sin and Math.cos optimizations that do not buy... (Closed)

Created:
11 years ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Remove complicated Math.sin and Math.cos optimizations that do not buy us much. Committed: http://code.google.com/p/v8/source/detail?r=3507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -207 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/arm/codegen-arm-inl.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/codegen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/codegen-ia32.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +3 lines, -71 lines 0 comments Download
M src/ia32/codegen-ia32-inl.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M src/x64/codegen-x64-inl.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years ago (2009-12-21 13:24:25 UTC) #1
Kasper Lund
11 years ago (2009-12-21 13:29:05 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698