Issue 5090001: Make use of the new version flag in Chrome to load the correct chrome.dll ver...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5090001: Make use of the new version flag in Chrome to load the correct chrome.dll ver... (Closed)

Created:
10 years, 1 month ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make use of the new version flag in Chrome to load the correct chrome.dll version. Also fix a memory leak in the Chrome Frame automation code. BUG=61609 TEST=Chrome.exe always loads the specified chrome.dll when run by Chrome Frame. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66462

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	chrome_frame/chrome_frame_automation.cc	View	1	3 chunks	+14 lines, -8 lines	0 comments	Download
	M	chrome_frame/chrome_launcher.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

robertshield

This makes CF run from the Chrome installation directory.

10 years, 1 month ago (2010-11-16 20:13:22 UTC) #1

lgtm!!!!!!!

Expand Messages | Collapse Messages