Issue 5089001: Cleanup: Include browser.h -> ui/browser.h [Part 3].

Issue 5089001: Cleanup: Include browser.h -> ui/browser.h [Part 3]. (Closed)

Created:
10 years, 1 month ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Cleanup: Include browser.h -> ui/browser.h [Part 3]. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66338

Patch Set 2 : Fixes. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -98 lines)			Patch
M	chrome/browser/accessibility/accessibility_win_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/accessibility/browser_views_accessibility_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_focus_uitest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/bug_report_data.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/custom_home_pages_table_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_http_protocol_handler.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_sanity_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_window.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/inspectable_tab_proxy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/device_orientation/device_orientation_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_manager.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_shelf.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_util.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/save_page_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/alert_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/all_urls_apitest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/app_background_page_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/app_process_apitest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/browser_action_apitest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/browser_action_test_util_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/browser_action_test_util_views.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/content_script_extension_process_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/execute_code_in_tab_function.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_accessibility_api.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_browser_actions_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_browser_event_router.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_browsertest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_browsertests_misc.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_context_menu_browsertest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_cookies_helpers.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_crash_recovery_browsertest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_devtools_browsertests.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_dom_ui.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_idle_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_incognito_apitest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_infobar_delegate.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_infobar_module.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_input_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_install_ui_browsertest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_management_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_omnibox_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_override_apitest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_page_actions_module.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_popup_api.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_process_manager.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_processes_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_proxy_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_startup_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_test_api.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_toolbar_model_browsertest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/notifications_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/page_action_apitest.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/external_tab_container_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/cookie_policy_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/predictor_api.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ssl/ssl_blocking_page.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ssl/ssl_browser_tests.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/toolbar_model.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_init_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_navigator.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_navigator_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/autofill_profiles_view_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmark_context_menu_controller_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/clear_browsing_data.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/dom_view_browsertest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/window_sizer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/window_sizer_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM but please fix the ordering. http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/browser_action_test_util_views.cc File chrome/browser/extensions/browser_action_test_util_views.cc (right): http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/browser_action_test_util_views.cc#newcode12 chrome/browser/extensions/browser_action_test_util_views.cc:12: #include "chrome/browser/ui/browser.h" u ...

10 years, 1 month ago (2010-11-16 20:01:28 UTC) #2

James Hawkins

10 years, 1 month ago (2010-11-16 20:43:29 UTC) #3

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/brows...
File chrome/browser/extensions/browser_action_test_util_views.cc (right):

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/brows...
chrome/browser/extensions/browser_action_test_util_views.cc:12: #include
"chrome/browser/ui/browser.h"
On 2010/11/16 20:01:28, Lei Zhang wrote:
> u before v.

Done.

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_dom_ui.cc (right):

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_dom_ui.cc:25: #include
"chrome/common/extensions/extension_constants.h"
On 2010/11/16 20:01:28, Lei Zhang wrote:
> same inconsistent ordering as page_action_apitest.cc

Done.

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_popup_api.cc (right):

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_popup_api.cc:11: #include
"chrome/browser/browser_window.h"
On 2010/11/16 20:01:28, Lei Zhang wrote:
> might as well replace this with ui/browser_window.h

Done.

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_toolbar_model_browsertest.cc (right):

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_toolbar_model_browsertest.cc:6: #include
"chrome/browser/extensions/extensions_service.h"
On 2010/11/16 20:01:28, Lei Zhang wrote:
> ordering

The ordering is correct. Strip out all punctuation and sort. s comes before t.

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/page_...
File chrome/browser/extensions/page_action_apitest.cc (right):

http://codereview.chromium.org/5089001/diff/1/chrome/browser/extensions/page_...
chrome/browser/extensions/page_action_apitest.cc:14: #include
"chrome/common/extensions/extension_action.h"
On 2010/11/16 20:01:28, Lei Zhang wrote:
> In ssl_browser_tests.cc, you have browser.h before browser_navigator.h, but
here
> you have extension_action.h before extension.h.

Strip out all punctuation and sort. h comes before n, a comes before h.

http://codereview.chromium.org/5089001/diff/1/chrome/browser/ui/views/dom_vie...
File chrome/browser/ui/views/dom_view_browsertest.cc (right):

http://codereview.chromium.org/5089001/diff/1/chrome/browser/ui/views/dom_vie...
chrome/browser/ui/views/dom_view_browsertest.cc:6: #include
"chrome/browser/ui/browser.h"
On 2010/11/16 20:01:28, Lei Zhang wrote:
> 'u' comes before 'v'.

Done.

Expand Messages | Collapse Messages