Issue 5085002: AU: Restrict SSL ciphers to HIGH in official builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5085002: AU: Restrict SSL ciphers to HIGH in official builds. (Closed)

Created:
10 years, 1 month ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git@master

Visibility:
Public.

Description

AU: Restrict SSL ciphers to HIGH in official builds. BUG=6407 TEST=unit tests, tested on device with the update server Change-Id: I72de989003c9177f23b1afddde051d9b8d8efa68 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e237d19

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	libcurl_http_fetcher.cc	View		1 chunk	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

petkov

This works, I think. Or it's better than nothing. Longer term, we should think more ...

10 years, 1 month ago (2010-11-16 17:58:27 UTC) #1

adlr

does this enforce a 128-bit or higher grade cypher? If so, LGTM

10 years, 1 month ago (2010-11-16 18:01:47 UTC) #2

petkov

On 2010/11/16 18:01:47, adlr wrote: > does this enforce a 128-bit or higher grade cypher? ...

10 years, 1 month ago (2010-11-16 18:04:16 UTC) #3

adlr

10 years, 1 month ago (2010-11-16 18:09:15 UTC) #4

cool. LGTM!

On Tue, Nov 16, 2010 at 10:04 AM, <petkov@chromium.org> wrote:

> On 2010/11/16 18:01:47, adlr wrote:
>
>> does this enforce a 128-bit or higher grade cypher? If so, LGTM
>>
>
> It's a bit better than that but works OK with the update server. OK?
>
>       HIGH
>           "high" encryption cipher suites. This currently means those with
> key
> lengths larger than 128 bits, and some cipher suites
>           with 128-bit keys.
>
>
> http://codereview.chromium.org/5085002/
>

Expand Messages | Collapse Messages