Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 5082002: Add a RevGitWithRetry method to retry repo sync and git push (Closed)

Created:
10 years, 1 month ago by scottz
Modified:
9 years, 7 months ago
Reviewers:
Raja Aluri, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils@master
Visibility:
Public.

Description

Add a RevGitWithRetry method to retry repo sync and git push Modify repo sync to just sync the repo we are in, this is what preflight does and is a proven acceptable approach over the complete 'repo sync' approach. BUG=8987 TEST=Ran retry command over dummy directories to be sure it retries as expected. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b593c39

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add in back off timeout #

Total comments: 2

Patch Set 3 : Added check in except clause #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -12 lines) Patch
M prebuilt.py View 1 2 7 chunks +40 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottz
10 years, 1 month ago (2010-11-16 17:17:14 UTC) #1
Raja Aluri
LGTM
10 years, 1 month ago (2010-11-16 17:25:17 UTC) #2
scottz
I decided i wanted a back off timeout so I added a 5 second * ...
10 years, 1 month ago (2010-11-16 17:28:03 UTC) #3
sosa
LGTM w/ nit http://codereview.chromium.org/5082002/diff/1/prebuilt.py File prebuilt.py (right): http://codereview.chromium.org/5082002/diff/1/prebuilt.py#newcode138 prebuilt.py:138: print 'Error pushing changes trying again ...
10 years, 1 month ago (2010-11-16 17:28:43 UTC) #4
sosa
http://codereview.chromium.org/5082002/diff/4001/prebuilt.py File prebuilt.py (right): http://codereview.chromium.org/5082002/diff/4001/prebuilt.py#newcode140 prebuilt.py:140: time.sleep(5*retry) nit: You sleep after the last try You ...
10 years, 1 month ago (2010-11-16 17:29:49 UTC) #5
scottz
PTAL. I added a check in the except clause to do the right thing. http://codereview.chromium.org/5082002/diff/4001/prebuilt.py ...
10 years, 1 month ago (2010-11-16 17:49:02 UTC) #6
sosa
10 years, 1 month ago (2010-11-16 17:57:33 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698