Issue 508020: Check for undefined in the binary operation stub when convertion to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 508020: Check for undefined in the binary operation stub when convertion to... (Closed)

Created:
11 years ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Check for undefined in the binary operation stub when convertion to int32 for bitops. undefined converts to zero in ToInt32 conversions. Committed: http://code.google.com/p/v8/source/detail?r=3512

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -4 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		2 chunks	+19 lines, -4 lines	0 comments	Download
	A	test/mjsunit/bitwise-operations-undefined.js	View		1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years ago (2009-12-22 09:48:17 UTC) #3

On 2009/12/22 09:36:16, Erik Corry wrote:
> LGTM.  Do we have tests for undefined on the lhs and rhs?

We do now.  Test added.

Expand Messages | Collapse Messages