Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: chrome/browser/external_tab_container_win.h

Issue 5075003: Converts usage of SetProp/GetProp to a map. Even after making sure we (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix gyp files Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « app/win/scoped_prop.h ('k') | chrome/browser/external_tab_container_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_ 5 #ifndef CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_
6 #define CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_ 6 #define CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 13 matching lines...) Expand all
24 #include "chrome/common/notification_registrar.h" 24 #include "chrome/common/notification_registrar.h"
25 #include "views/accelerator.h" 25 #include "views/accelerator.h"
26 #include "views/widget/widget_win.h" 26 #include "views/widget/widget_win.h"
27 27
28 class AutomationProvider; 28 class AutomationProvider;
29 class Profile; 29 class Profile;
30 class TabContentsContainer; 30 class TabContentsContainer;
31 class RenderViewContextMenuViews; 31 class RenderViewContextMenuViews;
32 32
33 namespace app { 33 namespace app {
34 namespace win { 34 class ViewProp;
35 class ScopedProp;
36 }
37 } 35 }
38 36
39 namespace IPC { 37 namespace IPC {
40 struct NavigationInfo; 38 struct NavigationInfo;
41 } 39 }
42 40
43 // This class serves as the container window for an external tab. 41 // This class serves as the container window for an external tab.
44 // An external tab is a Chrome tab that is meant to displayed in an 42 // An external tab is a Chrome tab that is meant to displayed in an
45 // external process. This class provides the FocusManger needed by the 43 // external process. This class provides the FocusManger needed by the
46 // TabContents as well as an implementation of TabContentsDelagate. 44 // TabContents as well as an implementation of TabContentsDelagate.
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 330
333 views::View* external_tab_view_; 331 views::View* external_tab_view_;
334 332
335 IPC::Message* unload_reply_message_; 333 IPC::Message* unload_reply_message_;
336 334
337 // set to true if the host needs to get notified of all top level navigations 335 // set to true if the host needs to get notified of all top level navigations
338 // in this page. This typically applies to hosts which would render the new 336 // in this page. This typically applies to hosts which would render the new
339 // page without chrome frame. 337 // page without chrome frame.
340 bool route_all_top_level_navigations_; 338 bool route_all_top_level_navigations_;
341 339
342 scoped_ptr<app::win::ScopedProp> prop_; 340 scoped_ptr<app::ViewProp> prop_;
343 341
344 DISALLOW_COPY_AND_ASSIGN(ExternalTabContainer); 342 DISALLOW_COPY_AND_ASSIGN(ExternalTabContainer);
345 }; 343 };
346 344
347 // This class is instantiated for handling requests to open popups for external 345 // This class is instantiated for handling requests to open popups for external
348 // tabs hosted in browsers which need to be notified about all top level 346 // tabs hosted in browsers which need to be notified about all top level
349 // navigations. An instance of this class is created for handling window.open 347 // navigations. An instance of this class is created for handling window.open
350 // or link navigations with target blank, etc. 348 // or link navigations with target blank, etc.
351 class TemporaryPopupExternalTabContainer : public ExternalTabContainer { 349 class TemporaryPopupExternalTabContainer : public ExternalTabContainer {
352 public: 350 public:
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 return false; 400 return false;
403 } 401 }
404 402
405 virtual void BeforeUnloadFired(TabContents* tab, bool proceed, 403 virtual void BeforeUnloadFired(TabContents* tab, bool proceed,
406 bool* proceed_to_fire_unload) { 404 bool* proceed_to_fire_unload) {
407 NOTREACHED(); 405 NOTREACHED();
408 } 406 }
409 }; 407 };
410 408
411 #endif // CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_ 409 #endif // CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_
OLDNEW
« no previous file with comments | « app/win/scoped_prop.h ('k') | chrome/browser/external_tab_container_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698