Fix omnibox update bug.

chrome/browser/ui/browser.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser.h"
 
 #if defined(OS_WIN)
 #include <shellapi.h>
 #include <windows.h>
 #endif  // OS_WIN
@@ skipping 3992 matching lines @@
   }
 }
 
 void Browser::CloseFrame() {
   window_->Close();
 }
 
 void Browser::TabDetachedAtImpl(TabContents* contents, int index,
                                 DetachType type) {
   if (type == DETACH_TYPE_DETACH) {
-    // Save what the user's currently typed.
-    window_->GetLocationBar()->SaveStateToContents(contents);
+    // Save what the user has typed in the location bar. But do this only if the

[Peter Kasting, 2010/11/17 01:41:24]

Nit: Might be clearer as:

// Save the current location bar state, but only if the tab being detached is
the selected tab.  Because saving state can conditionally revert the location
bar, saving the current tab's location bar state to a non-selected tab can
corrupt both tabs.

[sadrul, 2010/11/17 02:09:24]

Done.

+    // selected tab is detaching, because what the user typed would have been
+    // for the selected tab.
+    if (contents == GetSelectedTabContents())
+      window_->GetLocationBar()->SaveStateToContents(contents);
 
     if (!tab_handler_->GetTabStripModel()->closing_all())
       SyncHistoryWithTabs(0);
   }
 
   contents->set_delegate(NULL);
   RemoveScheduledUpdatesFor(contents);
 
   if (find_bar_controller_.get() &&
       index == tab_handler_->GetTabStripModel()->selected_index()) {
@@ skipping 69 matching lines @@
   NOTREACHED();
   return false;
 }
 
 void Browser::CreateInstantIfNecessary() {
   if (type() == TYPE_NORMAL && InstantController::IsEnabled(profile()) &&
       !profile()->IsOffTheRecord()) {
     instant_.reset(new InstantController(profile_, this));
   }
 }