Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 5074001: Fix username label's color (regression from r66060) (Closed)

Created:
10 years, 1 month ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix username label's color (regression from r66060) Change the font size to medium. BUG=chromium-os:9194 TEST=login and lock the screen using short power keypress. Confirm the uesrname has the same font/color as in login screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66343

Patch Set 1 #

Patch Set 2 : " #

Total comments: 4

Patch Set 3 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/chromeos/login/helper.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screen_lock_view.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_controller.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
10 years, 1 month ago (2010-11-16 05:16:01 UTC) #1
Daniel Erat
LGTM Does changing the font also increase the padding around the text to match what's ...
10 years, 1 month ago (2010-11-16 15:39:43 UTC) #2
oshima
On 2010/11/16 15:39:43, Daniel Erat wrote: > LGTM > > Does changing the font also ...
10 years, 1 month ago (2010-11-16 21:02:12 UTC) #3
Daniel Erat
LGTM http://codereview.chromium.org/5074001/diff/4001/chrome/browser/chromeos/login/screen_lock_view.cc File chrome/browser/chromeos/login/screen_lock_view.cc (right): http://codereview.chromium.org/5074001/diff/4001/chrome/browser/chromeos/login/screen_lock_view.cc#newcode75 chrome/browser/chromeos/login/screen_lock_view.cc:75: int username_height = login::kSelectedLabelHeight; // see fix comment ...
10 years, 1 month ago (2010-11-16 21:23:41 UTC) #4
oshima
i'm going to re-land this. http://codereview.chromium.org/5074001/diff/4001/chrome/browser/chromeos/login/screen_lock_view.cc File chrome/browser/chromeos/login/screen_lock_view.cc (right): http://codereview.chromium.org/5074001/diff/4001/chrome/browser/chromeos/login/screen_lock_view.cc#newcode75 chrome/browser/chromeos/login/screen_lock_view.cc:75: int username_height = login::kSelectedLabelHeight; ...
10 years, 1 month ago (2010-11-17 17:53:28 UTC) #5
oshima
10 years, 1 month ago (2010-11-17 18:02:26 UTC) #6
On 2010/11/17 17:53:28, oshima wrote:
> i'm going to re-land this.

my mistake. this wasn't revered.

> 
>
http://codereview.chromium.org/5074001/diff/4001/chrome/browser/chromeos/logi...
> File chrome/browser/chromeos/login/screen_lock_view.cc (right):
> 
>
http://codereview.chromium.org/5074001/diff/4001/chrome/browser/chromeos/logi...
> chrome/browser/chromeos/login/screen_lock_view.cc:75: int username_height =
> login::kSelectedLabelHeight;  // see
> On 2010/11/16 21:23:41, Daniel Erat wrote:
> > fix comment (just says "see")
> 
> Done.
> 
>
http://codereview.chromium.org/5074001/diff/4001/chrome/browser/chromeos/logi...
> chrome/browser/chromeos/login/screen_lock_view.cc:115:
> rb.GetFont(ResourceBundle::MediumBoldFont);
> On 2010/11/16 21:23:41, Daniel Erat wrote:
> > nit: this line can be unwrapped now
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698