Allow keypad 1..9 keys to be used as shortcuts to switch tabs....

Allow keypad 1..9 keys to be used as shortcuts to switch tabs.

BUG=63143
TEST=as in bug; also verify that it doesn't regress the feature with Italian keyboard layout which has numbers requiring shift


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66452

[Avi (use Gerrit), 2010-11-16 21:19:53]

BTW, support for using characters was added after these shortcuts, so that's
probably why they were left using keycodes.

[Nico, 2010-11-16 21:27:41]

can you check that this doesn't change how cmd-1…9 work with an italian keyboard
layout? (Italian layouts yield numbers on shift-1…9 and symbols unshifted.)

[Avi (use Gerrit), 2010-11-16 22:11:11]

Now it does :)

[Nico, 2010-11-16 22:21:14]

cool. is it hard to add a test for this (especially for the italian case)?

[Avi (use Gerrit), 2010-11-16 22:28:07]

The easy test is to make sure that any shortcut for the main keyboard works on
the number pad keys too. Italian feels harder; should I be recording and playing
back NSEvents? :(

[Nico, 2010-11-16 22:30:05]

On Tue, Nov 16, 2010 at 2:28 PM,  <avi@chromium.org> wrote:
> The easy test is to make sure that any shortcut for the main keyboard works
> on
> the number pad keys too. Italian feels harder; should I be recording and
> playing
> back NSEvents? :(

I think it's sufficient to call the function with key code != '1' but
virtual key code of the 1 key and make sure it returns the right thing
(with a comment saying "// This is how Italians roll.")

[Nico, 2010-11-16 23:19:34]

LG

thanks!

http://codereview.chromium.org/5072003/diff/9001/chrome/browser/global_keyboa...
File chrome/browser/global_keyboard_shortcuts_mac_unittest.mm (right):

http://codereview.chromium.org/5072003/diff/9001/chrome/browser/global_keyboa...
chrome/browser/global_keyboard_shortcuts_mac_unittest.mm:74: for (int i = 0; i <
10; ++i) {
arraysize(equivalents) (or UNSAFE_ARRAYSIZE(equivalents) if the former doesn't
work. i keep forgetting when it doesn't work.)

[Avi (use Gerrit), 2010-11-16 23:24:23]

http://codereview.chromium.org/5072003/diff/9001/chrome/browser/global_keyboa...
File chrome/browser/global_keyboard_shortcuts_mac_unittest.mm (right):

http://codereview.chromium.org/5072003/diff/9001/chrome/browser/global_keyboa...
chrome/browser/global_keyboard_shortcuts_mac_unittest.mm:74: for (int i = 0; i <
10; ++i) {
arraysize doesn't work because the array is of an anonymous type. Aha, it's
ARRAYSIZE_UNSAFE I was looking for and didn't find.