Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3382)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 5072002: Disable ClientSideDetectionServiceTest.SendClientReportPhishingRequest on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
index ce5e205575077fb8c3449ec3498256a1d4f50b44..dc1f99a0d761c6243a4dd0f7b1dc47cb2974891f 100644
--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
@@ -145,7 +145,14 @@ TEST_F(ClientSideDetectionServiceTest, TestFetchingModel) {
EXPECT_EQ(GetModelFile(), base::kInvalidPlatformFileValue);
}
-TEST_F(ClientSideDetectionServiceTest, SendClientReportPhishingRequest) {
+#if defined(OS_MACOSX)
+// Sometimes crashes on Mac 10.5 bot: http://crbug.com/63358
+#define MAYBE_SendClientReportPhishingRequest \
+ DISABLED_SendClientReportPhishingRequest
+#else
+#define MAYBE_SendClientReportPhishingRequest SendClientReportPhishingRequest
+#endif
+TEST_F(ClientSideDetectionServiceTest, MAYBE_SendClientReportPhishingRequest) {
SetModelFetchResponse("bogus model", true /* success */);
ScopedTempDir tmp_dir;
ASSERT_TRUE(tmp_dir.CreateUniqueTempDir());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698