Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3226)

Unified Diff: chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc

Issue 5072001: Improved activation logic to cover few more edge cases. Removed button that w... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/mobile_setup.html » ('j') | chrome/browser/resources/mobile_setup.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc
===================================================================
--- chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc (revision 66030)
+++ chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc (working copy)
@@ -563,10 +563,12 @@
}
break;
case chromeos::ACTIVATION_STATE_PARTIALLY_ACTIVATED:
- if (network->connected())
- new_state = PLAN_ACTIVATION_SHOWING_PAYMENT;
- else
+ if (network->connected()) {
+ if (network->restricted_pool())
+ new_state = PLAN_ACTIVATION_SHOWING_PAYMENT;
+ } else {
new_state = PLAN_ACTIVATION_RECONNECTING;
+ }
break;
case chromeos::ACTIVATION_STATE_NOT_ACTIVATED:
// Wait in this state until activation state changes.
@@ -588,6 +590,10 @@
} else {
new_state = PLAN_ACTIVATION_DONE;
}
+ } else if (network->failed()) {
+ chromeos::CrosLibrary::Get()->GetNetworkLibrary()->
+ ConnectToCellularNetwork(network);
+ return;
}
break;
case chromeos::ACTIVATION_STATE_PARTIALLY_ACTIVATED:
@@ -619,7 +625,8 @@
if ((network->activation_state() ==
chromeos::ACTIVATION_STATE_PARTIALLY_ACTIVATED ||
network->activation_state() == chromeos::ACTIVATION_STATE_ACTIVATING) &&
- network->error() == chromeos::ERROR_UNKNOWN &&
+ (network->error() == chromeos::ERROR_UNKNOWN ||
+ network->error() == chromeos::ERROR_OTASP_FAILED)&&
(state_ == PLAN_ACTIVATION_INITIATING_ACTIVATION ||
state_ == PLAN_ACTIVATION_RECONNECTING) &&
activation_status_test_ &&
« no previous file with comments | « no previous file | chrome/browser/resources/mobile_setup.html » ('j') | chrome/browser/resources/mobile_setup.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698