Add 1px black border for ChromeOS status button.

Add 1px black border for ChromeOS status button.

- Move Linux's CanvasSkia::DrawStringInt into DrawStringWithHalo and
  added code to support text halo and change DrawStringInt to use it;
- Make views::TextButton support text halo;
- Use the text halo for chromeos::StatusButton;

BUG=chromium-os:8657
TEST=Verify 1px black border is added to ChromeOS status buttons.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66632

[xiyuan, 2010-11-17 00:03:40]

I have added screenshots to the bug in case you want to take a look at the
result.

[DaveMoore, 2010-11-17 01:07:43]

http://codereview.chromium.org/5071002/diff/4001/gfx/canvas_skia_linux.cc
File gfx/canvas_skia_linux.cc (right):

http://codereview.chromium.org/5071002/diff/4001/gfx/canvas_skia_linux.cc#new...
gfx/canvas_skia_linux.cc:211: void CanvasSkia::DrawStringWithHalo(const
std::wstring& text,
I don't think this method should be called "DrawStringWithHalo()" as it can be
used to draw a string with no halo. It's code should be shared with
DrawStringInt() some other way.

[xiyuan, 2010-11-17 17:59:22]

http://codereview.chromium.org/5071002/diff/4001/gfx/canvas_skia_linux.cc
File gfx/canvas_skia_linux.cc (right):

http://codereview.chromium.org/5071002/diff/4001/gfx/canvas_skia_linux.cc#new...
gfx/canvas_skia_linux.cc:211: void CanvasSkia::DrawStringWithHalo(const
std::wstring& text,
On 2010/11/17 01:07:43, davemoore wrote:
> I don't think this method should be called "DrawStringWithHalo()" as it can be
> used to draw a string with no halo. It's code should be shared with
> DrawStringInt() some other way.

One possible way to share is wrapping the common code into
PreDrawingString/PostDrawingString and have DrawStringInt and DrawStringWithHalo
call them separately. 

Is this what you mean? Could you shed more lights on this? Thanks.

[xiyuan, 2010-11-17 19:55:05]

Please take another look.

I have changed the way to share common code by using a DrawStringContext class
to wrap up common pre/post drawing code.

[DaveMoore, 2010-11-18 00:11:59]

LGTM