Issue 507070: Add gclient_scm.GitWrapper.pack()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 507070: Add gclient_scm.GitWrapper.pack() (Closed)

Created:
11 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com, Mandeep Singh Baines

Visibility:
Public.

Description

Add gclient_scm.GitWrapper.pack() TEST=none BUG=none

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 1

Patch Set 3 : Cleaner path join #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -61 lines)			Patch
M	gclient_scm.py	View	1 2	6 chunks	+59 lines, -46 lines	0 comments	Download
M	scm.py	View	1	2 chunks	+39 lines, -12 lines	0 comments	Download
M	tests/gclient_scm_test.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/scm_unittest.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Bonus review since Mandeep isn't there. (stupid http 500 loosing text box values)

11 years ago (2009-12-22 20:55:05 UTC) #3

bradn

11 years ago (2009-12-22 21:29:03 UTC) #4

LGTM

http://codereview.chromium.org/507070/diff/3001/4001
File gclient_scm.py (right):

http://codereview.chromium.org/507070/diff/3001/4001#newcode35
gclient_scm.py:35: self._replacement_file = self._relpath + '/' + file
This is probably ok, but did you want to consider using posixpath instead?

Expand Messages | Collapse Messages