Issue 507061: Move GenerateDiff into a common function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 507061: Move GenerateDiff into a common function. (Closed)

Created:
11 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move GenerateDiff into a common function. Fix standalone trychange usage on both svn and git. Remove implicit dependency on git-cl. TEST=unit test

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : descriptions #

Total comments: 1

Patch Set 4 : mult #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -121 lines)			Patch
M	gcl.py	View		1 chunk	+1 line, -40 lines	0 comments	Download
M	scm.py	View	1 2 3	6 chunks	+182 lines, -44 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	tests/gclient_utils_test.py	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/scm_unittest.py	View	1	3 chunks	+9 lines, -5 lines	0 comments	Download
M	tests/trychange_unittest.py	View	1	3 chunks	+6 lines, -11 lines	0 comments	Download
M	trychange.py	View	1	4 chunks	+12 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

I tested git-try, gcl try, trychange.py on both git and svn checkout. trychange on svn ...

11 years ago (2009-12-21 21:51:52 UTC) #1

bradn

11 years ago (2009-12-21 23:39:30 UTC) #2

LGTM

http://codereview.chromium.org/507061/diff/3001/3003
File scm.py (right):

http://codereview.chromium.org/507061/diff/3001/3003#newcode529
scm.py:529: data +=
("=========================================================="
data += '=' * 30

Expand Messages | Collapse Messages