Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: src/regexp-macro-assembler-tracer.cc

Issue 507051: Attempt to make \b\w+ faster. Slight performance increase on, e.g., string unpacking. (Closed)
Patch Set: Addressed review comments. Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/regexp-macro-assembler-tracer.h ('k') | src/x64/regexp-macro-assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 for (int i = 0; i < str.length(); i++) { 300 for (int i = 0; i < str.length(); i++) {
301 PrintF("u%04x", str[i]); 301 PrintF("u%04x", str[i]);
302 } 302 }
303 PrintF("\", cp_offset=%d, label[%08x])\n", cp_offset, on_failure); 303 PrintF("\", cp_offset=%d, label[%08x])\n", cp_offset, on_failure);
304 assembler_->CheckCharacters(str, cp_offset, on_failure, check_end_of_string); 304 assembler_->CheckCharacters(str, cp_offset, on_failure, check_end_of_string);
305 } 305 }
306 306
307 307
308 bool RegExpMacroAssemblerTracer::CheckSpecialCharacterClass( 308 bool RegExpMacroAssemblerTracer::CheckSpecialCharacterClass(
309 uc16 type, 309 uc16 type,
310 int cp_offset,
311 bool check_offset,
312 Label* on_no_match) { 310 Label* on_no_match) {
313 bool supported = assembler_->CheckSpecialCharacterClass(type, 311 bool supported = assembler_->CheckSpecialCharacterClass(type,
314 cp_offset,
315 check_offset,
316 on_no_match); 312 on_no_match);
317 PrintF(" CheckSpecialCharacterClass(type='%c', offset=%d, " 313 PrintF(" CheckSpecialCharacterClass(type='%c', label[%08x]): %s;\n",
318 "check_offset=%s, label[%08x]): %s;\n",
319 type, 314 type,
320 cp_offset,
321 check_offset ? "true" : "false",
322 on_no_match, 315 on_no_match,
323 supported ? "true" : "false"); 316 supported ? "true" : "false");
324 return supported; 317 return supported;
325 } 318 }
326 319
327 320
328 void RegExpMacroAssemblerTracer::IfRegisterLT(int register_index, 321 void RegExpMacroAssemblerTracer::IfRegisterLT(int register_index,
329 int comparand, Label* if_lt) { 322 int comparand, Label* if_lt) {
330 PrintF(" IfRegisterLT(register=%d, number=%d, label[%08x]);\n", 323 PrintF(" IfRegisterLT(register=%d, number=%d, label[%08x]);\n",
331 register_index, comparand, if_lt); 324 register_index, comparand, if_lt);
(...skipping 22 matching lines...) Expand all
354 return assembler_->Implementation(); 347 return assembler_->Implementation();
355 } 348 }
356 349
357 350
358 Handle<Object> RegExpMacroAssemblerTracer::GetCode(Handle<String> source) { 351 Handle<Object> RegExpMacroAssemblerTracer::GetCode(Handle<String> source) {
359 PrintF(" GetCode(%s);\n", *(source->ToCString())); 352 PrintF(" GetCode(%s);\n", *(source->ToCString()));
360 return assembler_->GetCode(source); 353 return assembler_->GetCode(source);
361 } 354 }
362 355
363 }} // namespace v8::internal 356 }} // namespace v8::internal
OLDNEW
« no previous file with comments | « src/regexp-macro-assembler-tracer.h ('k') | src/x64/regexp-macro-assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698