Move sanity checks for missing directories until after checkout happens.

Move sanity checks for missing directories until after checkout happens.

Preflight clean needs to wait until after the checkout happens before
it asserts that all of our overlays exist.

BUG=chromium-os:9197
TEST=Ran cbuildbot.py with missing chromiumos-overlay dir

Change-Id: If66574f01d1e85741e971919a9fa2da34f85872d

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=77f281a

[sosa, 2010-11-16 02:37:43]

http://codereview.chromium.org/5069001/diff/1/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/5069001/diff/1/bin/cbuildbot.py#newcode264
bin/cbuildbot.py:264: _GitCleanup(buildroot, board, tracking_branch)
Does this break git cleanup of some overlays?

[davidjames, 2010-11-16 02:55:41]

http://codereview.chromium.org/5069001/diff/1/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/5069001/diff/1/bin/cbuildbot.py#newcode264
bin/cbuildbot.py:264: _GitCleanup(buildroot, board, tracking_branch)
On 2010/11/16 02:37:44, sosa wrote:
> Does this break git cleanup of some overlays?

cros_mark_as_stable defaults to cleaning up all of the overlays it can find.
Still, I don't like this solution very much -- it'd be better to just move the
check.

I've moved the check instead now. PTAL.

[sosa, 2010-11-16 03:15:26]

LGTM

[scottz, 2010-11-16 03:45:42]

LGTM, 

I am not sure about the asserts we are adding to this code here though. I don't
understand why we are using asserts to test for them and I also do not
understand the danger of these "creeping" in. It seems to be that if : are
sneaking in we have other problems.

http://codereview.chromium.org/5069001/diff/5001/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/5069001/diff/5001/bin/cbuildbot.py#newcode537
bin/cbuildbot.py:537: assert ':' not in path, 'Overlay must not contain colons:
%s' % path
Why are we putting asserts in here still? From your last comment it sounded like
this wasn't really necessary.