Issue 5068001: Move move classes to the remoting::protocol namespace. Minor cleanups.

Issue 5068001: Move move classes to the remoting::protocol namespace. Minor cleanups. (Closed)

Created:
10 years, 1 month ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
garykac, Alpha Left Google

CC:
chromium-reviews, Sergey Ulanov, dmac, awong, garykac, Paweł Hajdan Jr., pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move move classes to the remoting::protocol namespace. Minor cleanups. BUG=None TEST=compiles, unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68056

Patch Set 2 : Moved MouseButton enum in MouseEvent #

Patch Set 4 : Fixed mac and win #

Patch Set 7 : more fixes for windows #

Total comments: 4

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -64 lines)			Patch
M	remoting/base/decoder_row_based.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	remoting/client/input_handler.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/client/input_handler.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	remoting/client/plugin/pepper_input_handler.cc	View	1 2	2 chunks	+8 lines, -5 lines	0 comments	Download
M	remoting/client/x11_input_handler.cc	View	1 2 3 4 5	2 chunks	+8 lines, -5 lines	0 comments	Download
M	remoting/host/event_executor_linux.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/host/event_executor_linux.cc	View	1	2 chunks	+10 lines, -5 lines	0 comments	Download
M	remoting/host/event_executor_mac.h	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/host/event_executor_mac.cc	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	remoting/host/event_executor_win.h	View	1 2 3 4 5 6	1 chunk	+4 lines, -4 lines	0 comments	Download
M	remoting/host/event_executor_win.cc	View	1 2 3	3 chunks	+8 lines, -6 lines	0 comments	Download
M	remoting/proto/control.proto	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	remoting/proto/event.proto	View	1	2 chunks	+9 lines, -8 lines	0 comments	Download
M	remoting/proto/internal.proto	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	remoting/proto/video.proto	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	remoting/protocol/client_control_sender.cc	View		2 chunks	+2 lines, -1 line	2 comments	Download
M	remoting/protocol/host_message_dispatcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/protocol/host_message_dispatcher.cc	View		1 chunk	+1 line, -0 lines	2 comments	Download
M	remoting/protocol/input_stub.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	remoting/protocol/message_decoder.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	remoting/protocol/message_decoder.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	remoting/protocol/message_decoder_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	remoting/protocol/message_reader.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	remoting/protocol/message_reader.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	remoting/protocol/util.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	remoting/protocol/util.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

http://codereview.chromium.org/5068001/diff/19001/remoting/protocol/client_control_sender.cc File remoting/protocol/client_control_sender.cc (right): http://codereview.chromium.org/5068001/diff/19001/remoting/protocol/client_control_sender.cc#newcode13 remoting/protocol/client_control_sender.cc:13: #include "remoting/proto/internal.pb.h" On 2010/12/02 19:41:59, Alpha wrote: > why ...

10 years ago (2010-12-02 20:06:39 UTC) #2

ok. LGTM.

Expand Messages | Collapse Messages