Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5066002: X11: Make the default X11 error handler non-fatal. (Closed)

Created:
10 years, 1 month ago by Lei Zhang
Modified:
9 years, 7 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

X11: Make the default X11 error handler non-fatal. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66355

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M app/x11_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_main.cc View 1 3 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Apps should be able to continue past an X11 error. (plus I'm tired of seeing ...
10 years, 1 month ago (2010-11-16 22:03:44 UTC) #1
DaveMoore
LGTM
10 years, 1 month ago (2010-11-17 01:03:53 UTC) #2
apatrick_chromium
10 years, 1 month ago (2010-11-17 01:18:00 UTC) #3 
Reviewing only gpu_main.cc. LG.

Powered by Google App Engine
This is Rietveld 408576698