Issue 5065001: Move creation of capturer, input stub into ChromotingHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5065001: Move creation of capturer, input stub into ChromotingHost (Closed)

Created:
10 years, 1 month ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
Sergey Ulanov, dmac, awong, garykac

CC:
chromium-reviews, Sergey Ulanov, awong, garykac, Alpha Left Google

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move creation of capturer, input stub into ChromotingHost BUG=None TEST=None

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -86 lines)			Patch
M	chrome/service/service_process.cc	View	2 chunks	+1 line, -36 lines	0 comments	Download
M	remoting/host/chromoting_host.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	remoting/host/chromoting_host.cc	View	2 chunks	+27 lines, -6 lines	0 comments	Download
M	remoting/host/simple_host_process.cc	View	4 chunks	+1 line, -42 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

I think we should keep fake capturer working. It's still useful. Looks good otherwise. http://codereview.chromium.org/5065001/diff/1/remoting/host/simple_host_process.cc ...

10 years, 1 month ago (2010-11-17 03:29:19 UTC) #4

dmac

I agree with sergey. LGTM if we keep the fake capturer going unless this is ...

10 years, 1 month ago (2010-11-17 04:34:20 UTC) #5

dmac

10 years, 1 month ago (2010-11-17 04:34:28 UTC) #6

I agree with sergey. LGTM if we keep the fake capturer going unless this is
extremely difficult to do.

Expand Messages | Collapse Messages