Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4683)

Unified Diff: chrome/common/extensions/api/extension_api.json

Issue 5064001: More changes to extension omnibox API for styles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: offset Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_api.json
diff --git a/chrome/common/extensions/api/extension_api.json b/chrome/common/extensions/api/extension_api.json
index 5e8c19b95274f7be05011762b4b8e0b4879530be..23d705513af2539e353cd005ce69cf13f4b80ebc 100644
--- a/chrome/common/extensions/api/extension_api.json
+++ b/chrome/common/extensions/api/extension_api.json
@@ -3928,13 +3928,13 @@
"descriptionStyles": {
"type": "array",
"optional": true,
- "description": "An array of style objects, created using styleUrl, styleMatch, or styleDim. A style applies to the region of text specified by the style's starting offset and length. If there are any overlapping regions of text covered by multiple styles, the last-specified style will be applied to the overlapping region.",
+ "description": "An array of style objects, created using styleUrl, styleMatch, or styleDim. A style applies to the region of text specified by the style's starting offset and length. If there are any overlapping regions of text covered by multiple styles, they will be added together (e.g. 'match' + 'dim' will display a dimmed match). Not all style combinations will be visually distinct (e.g. 'url' + 'dim' may look identical to 'url').",
"items": {
"type": "object",
"properties": {
"type": {"type": "string", "enum": ["url", "match", "dim"]},
"offset": {"type": "integer"},
- "length": {"type": "integer"}
+ "length": {"type": "integer", "optional": true}
}
}
}
@@ -3961,28 +3961,28 @@
{
"name": "styleUrl",
"type": "function",
- "description": "Constructor for the descriptionStyles parameter of the suggest callback. This style designates a region of text matching a URL or filename.",
+ "description": "Constructor for the descriptionStyles parameter of the suggest callback. This style designates a region of text matching a URL or filename. A negative offset means the region will start at that many characters from the end of the description. If length is omitted, the region will apply for the rest of the description text.",
"parameters": [
{"type": "integer", "name": "offset", "minimum": 0},
- {"type": "integer", "name": "length", "minimum": 1}
+ {"type": "integer", "name": "length", "minimum": 0, "optional": true}
]
},
{
"name": "styleMatch",
"type": "function",
- "description": "Constructor for the descriptionStyles parameter of the suggest callback. This style designates a region of text matching what the user typed.",
+ "description": "Constructor for the descriptionStyles parameter of the suggest callback. This style designates a region of text matching what the user typed. A negative offset means the region will start at that many characters from the end of the description. If length is omitted, the region will apply for the rest of the description text.",
"parameters": [
{"type": "integer", "name": "offset", "minimum": 0},
- {"type": "integer", "name": "length", "minimum": 1}
+ {"type": "integer", "name": "length", "minimum": 0, "optional": true}
]
},
{
"name": "styleDim",
"type": "function",
- "description": "Constructor for the descriptionStyles parameter of the suggest callback. This style designates a region of dim helper text.",
+ "description": "Constructor for the descriptionStyles parameter of the suggest callback. This style designates a region of dim helper text. A negative offset means the region will start at that many characters from the end of the description. If length is omitted, the region will apply for the rest of the description text.",
"parameters": [
{"type": "integer", "name": "offset", "minimum": 0},
- {"type": "integer", "name": "length", "minimum": 1}
+ {"type": "integer", "name": "length", "minimum": 0, "optional": true}
]
}
],
« no previous file with comments | « chrome/browser/extensions/extension_omnibox_unittest.cc ('k') | chrome/common/extensions/docs/experimental.omnibox.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698